Build example project #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elliekwon
reviewed
Sep 26, 2025
Comment on lines
+26
to
+27
| # https://stackoverflow.com/a/77513296 | ||
| config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '12.0' |
There was a problem hiding this comment.
あ、今まではミニマムのターゲットがいなかったんですね。
QLEARN_DEPLOYMENT_TARGET 17.0とは異なりますが、QLearnより高くなければ何でも問題はないので良さそう🙆♀️
|
runner が古い (macOS-11) ので CI が回りませんね。 https://github.com/quipper/MessageKit/blob/master/.github/workflows/ci_pr_tests.yml#L8 直すのが大変なのと、この PR のスコープは example project のビルドだけなので merge しちゃいます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/quipper/aya-issues/issues/94298 の対応のため sample project でビルドして動作確認したかったが、Xcode 16.4 / Ruby 3.3.6 でビルドができなかったので修正しました。
なお、これまでの変更箇所が多すぎて upstream に追従するのはもはや不可能に思えます。